Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Combobox adds aria-invalid when in an error state #27651

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Combobox adds aria-invalid when in an error state #27651

wants to merge 3 commits into from
+17 −0

Conversation

smhigley
Copy link
Contributor

This fixes a bug I noticed while we were discussing timepicker validation. Combobox currently doesn't set aria-invalid when in an errored state.

Now it is set based on whether errorMessage is defined, which is also how the red border styling is determined.

@smhigley smhigley requested review from a team as code owners April 21, 2023 17:58
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 21, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 21, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 294cb96:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 21, 2023 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ComboBox 241.519 kB 241.559 kB ExceedsBaseline     40 bytes
office-ui-fabric-react fluentui-react-TimePicker 231.671 kB 231.711 kB ExceedsBaseline     40 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 12002074600ba914ae927135db1b0d38c83ad547 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 21, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 12002074600ba914ae927135db1b0d38c83ad547

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 21, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 618 638 5000
Breadcrumb mount 1688 1678 1000
Checkbox mount 1670 1701 5000
CheckboxBase mount 1496 1458 5000
ChoiceGroup mount 2908 2954 5000
ComboBox mount 686 687 1000
CommandBar mount 6209 6205 1000
ContextualMenu mount 12546 12421 1000
DefaultButton mount 749 748 5000
DetailsRow mount 2169 2213 5000
DetailsRowFast mount 2159 2172 5000
DetailsRowNoStyles mount 2056 2045 5000
Dialog mount 2850 2710 1000
DocumentCardTitle mount 245 233 1000
Dropdown mount 2019 1989 5000
FocusTrapZone mount 1129 1109 5000
FocusZone mount 1072 1068 5000
GroupedList mount 41007 41894 2
GroupedList virtual-rerender 19793 19771 2
GroupedList virtual-rerender-with-unmount 49880 50143 2
GroupedListV2 mount 233 231 2
GroupedListV2 virtual-rerender 205 210 2
GroupedListV2 virtual-rerender-with-unmount 228 233 2
IconButton mount 1067 1085 5000
Label mount 336 334 5000
Layer mount 2690 2685 5000
Link mount 385 381 5000
MenuButton mount 936 916 5000
MessageBar mount 21239 21222 5000
Nav mount 1877 1891 1000
OverflowSet mount 795 769 5000
Panel mount 1749 1746 1000
Persona mount 733 745 1000
Pivot mount 852 836 1000
PrimaryButton mount 834 844 5000
Rating mount 4591 4549 5000
SearchBox mount 900 879 5000
Shimmer mount 1907 1875 5000
Slider mount 1316 1334 5000
SpinButton mount 2842 2817 5000
Spinner mount 396 392 5000
SplitButton mount 1783 1823 5000
Stack mount 398 402 5000
StackWithIntrinsicChildren mount 862 880 5000
StackWithTextChildren mount 2637 2622 5000
SwatchColorPicker mount 5945 6116 5000
TagPicker mount 1426 1426 5000
Text mount 379 375 5000
TextField mount 955 900 5000
ThemeProvider mount 833 842 5000
ThemeProvider virtual-rerender 572 577 5000
ThemeProvider virtual-rerender-with-unmount 1258 1271 5000
Toggle mount 609 593 5000
buttonNative mount 187 196 5000

@smhigley @sopranopillow
Change file typo fix
294cb96 
Co-authored-by: Esteban Munoz Facusse <[email protected]>
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopranopillow sopranopillow sopranopillow approved these changes

Assignees

@khmakoto khmakoto

Labels
Component: Combobox
Projects
None yet
Milestone
June Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@smhigley @fabricteam @sopranopillow @khmakoto @msft-fluent-ui-bot